Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML entities are not removed from ZIM article titles #38

Closed
kelson42 opened this issue Aug 4, 2020 · 2 comments
Closed

HTML entities are not removed from ZIM article titles #38

kelson42 opened this issue Aug 4, 2020 · 2 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@kelson42
Copy link
Contributor

kelson42 commented Aug 4, 2020 •
edited
Loading

See for example "Jean Aicard - L'Illustre Maurin ( EPUB et PDF gratuits )" in bouquineux.zim which gives Jean Aicard - L'Illustre Maurin ( EPUB et PDF gratuits ) in kiwix-serve suggestions (one time chosen).
@kelson42 kelson42 added the bug Something isn't working label Aug 4, 2020
@rgaudin
Copy link
Member

rgaudin commented Aug 4, 2020

  • the page title doesn't encode this.
  • I checked the WARC and it's content doesn't have it encoded.
  • the python code doesn't encode it neither.
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Jean Aicard - Notre-Dame-d'Amour ( EPUB et PDF gratuits )</title>
<META NAME="Description" CONT

I've looked at kiwixlib quickly and we don't appear to do much there neither. The suggested list items are not encoded neither so it seems to be solely related to the taskbar JS:

jk( "#kiwixsearchbox" ).autocomplete({

  source: "{{root}}/suggest?content={{#urlencoded}}{{{content}}}{{/urlencoded}}",
  dataType: "json",
  cache: false,

  select: function(event, ui) {
  jk( "#kiwixsearchbox" ).val(ui.item.value);
  jk( "#kiwixsearchform" ).submit();
  },

  });

head_part.html

@mgautierfr can maybe explain with we use {{#urlencoded}} here?

@rgaudin rgaudin closed this as completed Aug 4, 2020
@rgaudin rgaudin added the wontfix This will not be worked on label Aug 4, 2020
@kelson42 kelson42 reopened this Aug 4, 2020
@ghost ghost mentioned this issue Aug 4, 2020
Closed
@ghost ghost deleted a comment from kelson42 Aug 4, 2020
@ghost
Copy link

ghost commented Aug 4, 2020

This issue was moved by kelson42 to kiwix/kiwix-lib#398.

@ghost ghost closed this as completed Aug 4, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgaudin @kelson42