Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup a test website with all weird JS situations #166

Closed
benoit74 opened this issue Jan 31, 2024 · 3 comments · Fixed by #184
Closed

Setup a test website with all weird JS situations #166

benoit74 opened this issue Jan 31, 2024 · 3 comments · Fixed by #184
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@benoit74
Copy link
Collaborator

See #165 (comment)

We need to setup a test website (and associated Zimfarm recipe) grouping all "weird" JS situations that are fixed by wabac DS rules at src/warc2zim/content_rewriting/ds.py, so that it will be quick to test all of them at once.

@benoit74 benoit74 added the enhancement New feature or request label Jan 31, 2024
@kelson42
Copy link
Contributor

@benoit74 Yes, this can be easily done with https://pages.github.com/

@benoit74
Copy link
Collaborator Author

I'm not concerned about the technical side (we could also setup a small website on our own infra, but you are right Github Pages is maybe even more straightforward).

I'm more concerned about ensuring we have the proper content inside the test website so that we test all weird situations, and we need expertise on that.

@kelson42
Copy link
Contributor

kelson42 commented Mar 6, 2024

Fixed by #184

@kelson42 kelson42 closed this as completed Mar 6, 2024
@kelson42 kelson42 added this to the 2.0.0 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants