Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt python bootstrap standards #152

Closed
benoit74 opened this issue Jan 18, 2024 · 6 comments
Closed

Adopt python bootstrap standards #152

benoit74 opened this issue Jan 18, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@benoit74
Copy link
Collaborator

No description provided.

@benoit74 benoit74 added the enhancement New feature or request label Jan 18, 2024
@benoit74 benoit74 added this to the 2.0.0 milestone Jan 18, 2024
@benoit74 benoit74 self-assigned this Jan 18, 2024
@kelson42
Copy link
Contributor

kelson42 commented Jan 18, 2024

@benoit74 Is that somehow blocking or strongly impacting Zimit2? If "yes" how? If "no, would recommend to remove it from the Zimit2.0 project.

@rgaudin
Copy link
Member

rgaudin commented Jan 18, 2024

That's what we discussed during the initial zimit2 PR. We agreed we'd do it right after @mgautierfr finishes so I guess that's why @benoit74 included it.
It's not a big effort and @benoit74 already switched zimit (smaller though) so I'd advise we keep it but it's not required.

@kelson42
Copy link
Contributor

@rgaudin Thx, make sense. Was kind of focused on Milestone 1 by @mgautierfr and have forgotten Milestone 2 handled by @benoit74... but at the end it seems we want to handle everything with the same Github project.

@benoit74
Copy link
Collaborator Author

PR for warc2zim is almost ready indeed ; while it is not a blocker, it might impact Zimit2 in the sense that it will be a significant list of small subtle changes in the codebase and as such I would prefer to do it while we have a lot of attention on warc2zim / zimit

@kelson42
Copy link
Contributor

@benoit74 I think this has been fixed by #154 right?

@rgaudin
Copy link
Member

rgaudin commented Jan 29, 2024

Right

@rgaudin rgaudin closed this as completed Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants