Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilanguage ZIM seem not handle properly #180

Closed
kelson42 opened this issue Apr 7, 2024 · 2 comments
Closed

Multilanguage ZIM seem not handle properly #180

kelson42 opened this issue Apr 7, 2024 · 2 comments
Milestone

Comments

@kelson42
Copy link
Contributor

kelson42 commented Apr 7, 2024

Recent TED file:
image

Unable to be found if English language filter:
image

... although it should be possible to find it.

The "MUL" at the bottom left seems also a hint that something is wrong.

@kelson42 kelson42 added this to the 3.0.0 milestone Apr 7, 2024
@rgaudin
Copy link
Member

rgaudin commented Apr 8, 2024

This is clearly a scraper/ZIM issue:

❯ curl https://dev.library.kiwix.org/raw/ted_mul_capitalism_2024-03/meta/Language
mul

But I believe it shouldn't be possible since #170 which isn't perfect (but should not write mul) and will be correct with #171.
I believe this run isn't using it since there hasn't been a release since. @benoit74 can you check that I'm correct and close ?

@benoit74
Copy link
Collaborator

benoit74 commented Apr 8, 2024

Sorry for the long feedback, I wanted to check everything before making a wrong statement.

This is indeed mostly already covered by #170 and #171 which are not yet released, before that ZIM language metadata was ... crappy.

> curl https://library.kiwix.org/raw/ted_mul_capitalism_2024-03/meta/Scraper
ted2zim 2.1.0

With main, the Language metadata is now properly set to a CSV list of languages. However it is not sorted properly, we only set eng as first language if present. Definitely a hack, but covers most (all?) the ZIMs we produce.

The remaining part (sorting languages in proper order) has to be covered by #172

@benoit74 benoit74 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants