From b79554cb2b99cc386accdb173b795fdc5d3626fc Mon Sep 17 00:00:00 2001
From: benoit74 <benoit74@users.noreply.github.com>
Date: Tue, 14 May 2024 08:38:06 +0000
Subject: [PATCH] Retry HTTP calls on any error occuring during the request,
 not only bad HTTP status code

---
 CHANGELOG.md         |  1 +
 src/ted2zim/utils.py | 24 ++++++++++++------------
 2 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 1f0a903..f964c43 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 
 - Change log level from ERROR to WARNING for missing translations (#197)
+- Fix HTTP retries to consider any HTTP failure, not only bad HTTP status code (#162)
 
 ## [3.0.0] - 2024-04-19
 
diff --git a/src/ted2zim/utils.py b/src/ted2zim/utils.py
index b826edb..b127477 100644
--- a/src/ted2zim/utils.py
+++ b/src/ted2zim/utils.py
@@ -38,19 +38,19 @@ def request_url(url, json_data=None):
         url = f"{BASE_URL}playlists/57/björk_6_talks_that_are_music"
     max_attempts, attempt = 5, 1
     while True:
-        time.sleep(1)  # delay requests
-        if json_data:
-            req = requests.post(
-                url,
-                headers={"User-Agent": "Mozilla/5.0"},
-                json=json_data,
-                timeout=REQUESTS_TIMEOUT,
-            )
-        else:
-            req = requests.get(
-                url, headers={"User-Agent": "Mozilla/5.0"}, timeout=REQUESTS_TIMEOUT
-            )
         try:
+            time.sleep(1)  # delay requests
+            if json_data:
+                req = requests.post(
+                    url,
+                    headers={"User-Agent": "Mozilla/5.0"},
+                    json=json_data,
+                    timeout=REQUESTS_TIMEOUT,
+                )
+            else:
+                req = requests.get(
+                    url, headers={"User-Agent": "Mozilla/5.0"}, timeout=REQUESTS_TIMEOUT
+                )
             req.raise_for_status()
             return req
         except Exception as exc: