Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename validate_zimfile_creatable to validate_file_creatable and add validate_folder_writable #200

Open
benoit74 opened this issue Oct 3, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@benoit74
Copy link
Collaborator

benoit74 commented Oct 3, 2024

In validate_zimfile_creatable, nothing is specifically tied to the fact that we are manipulating a ZIM file.

The method should hence be renamed validate_file_creatable. Obviously this would be a breaking change, so probably needs to be done in two steps, first create new name and keep alias with old name, with a "deprecated" warning. Then delete old name in a major release.

And sometimes we just want to check that we can create a file in a given folder. Code is mostly identical (and should be shared) but we would benefit from having a validate_folder_writable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant