Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow specifying reencode's tmp dir #162

Open
rgaudin opened this issue May 14, 2024 · 1 comment
Open

allow specifying reencode's tmp dir #162

rgaudin opened this issue May 14, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@rgaudin
Copy link
Member

rgaudin commented May 14, 2024

reencode() uses a temporary file to encode into.

Once ffmpeg complete, if all went well, that temp file is copied into destination.

  • Copying is very safe (considering we could be on different filesystems) but it's unnecessarily slow if on the same filesystem. We should first attempt to move and only copy as fallback.
  • encoding is not just CPU intensive, it can consume a lot of space and is subject to disk speed to some extent. For those reasons, we should be able to provide a temp folder to use and only fallback to system's should it not be provided.
@rgaudin rgaudin added the enhancement New feature or request label May 14, 2024
@benoit74
Copy link
Collaborator

Agreed!

@benoit74 benoit74 modified the milestone: 4.0.0 Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgaudin @benoit74