Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle_user_provided_file should set a User-Agent #103

Closed
rgaudin opened this issue May 25, 2023 · 0 comments · Fixed by #141
Closed

handle_user_provided_file should set a User-Agent #103

rgaudin opened this issue May 25, 2023 · 0 comments · Fixed by #141
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
3.3.1

Comments

@rgaudin
Copy link
Member

rgaudin commented May 25, 2023

Although this function is not used for mass downloads but just to pick a couple files per scrape, because this is good practice, and because files hosted on Wikimedia servers require it, we should set a User-Agent for requests emited through it.

https://meta.wikimedia.org/wiki/User-Agent_policy
@rgaudin rgaudin added enhancement New feature or request good first issue Good for newcomers labels May 25, 2023
@aryanA101a aryanA101a mentioned this issue Feb 21, 2024
Merged
@benoit74 benoit74 added this to the 3.4.0 milestone Feb 27, 2024
@benoit74 benoit74 modified the milestones: 3.4.0, 3.3.1 Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
3.3.1
Development

Successfully merging a pull request may close this issue.

set a user-agent for handle_user_provided_file aryanA101a/python-scraperlib
2 participants
@rgaudin @benoit74