Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--verbose should be able to get a log threshold #674

Closed
kelson42 opened this issue Apr 14, 2019 · 6 comments · Fixed by #1785
Closed

--verbose should be able to get a log threshold #674

kelson42 opened this issue Apr 14, 2019 · 6 comments · Fixed by #1785
Assignees
@pavel-karatsiuba
Labels
enhancement good first issue
Milestone
1.13.0

Comments

@kelson42
Copy link
Collaborator

kelson42 commented Apr 14, 2019 •
edited
Loading

The --verbose option works as a boolean option for now. This should continue to be able to work that way but we should also be able to put a log level, under which, any log message should not be displayed.

For example --verbose=warning will print all errors above warning, ie. warning and error probably.
@kelson42 kelson42 added this to the 2.0 milestone Apr 14, 2019
@stale
Copy link

stale bot commented Aug 3, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Aug 3, 2019
@kelson42 kelson42 modified the milestones: 2.0, 1.10 Sep 2, 2019
@stale stale bot removed stale labels Sep 2, 2019
@stale
Copy link

stale bot commented Nov 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Nov 1, 2019
@kelson42 kelson42 modified the milestones: 1.10, 2.0 Apr 9, 2020
@stale stale bot removed stale labels Apr 9, 2020
@stale
Copy link

stale bot commented Jun 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Jun 8, 2020
@kelson42 kelson42 modified the milestones: 2.0, 1.12 Dec 31, 2020
@kelson42 kelson42 modified the milestones: 1.14.0_old, 1.14.0 Jan 20, 2023
@stale stale bot removed stale labels Jan 20, 2023
@kelson42
Copy link
Collaborator Author

kelson42 commented Feb 4, 2023 •
edited
Loading

@uriesk Does that proposal sounds a reasonable way to be more flexible with logging printing on terminal?

@holta holta mentioned this issue Feb 4, 2023
Closed
@uriesk
Copy link
Collaborator

uriesk commented Feb 4, 2023

@uriesk yes, sounds great

@kelson42 kelson42 modified the milestones: 1.14.0, 1.13.0 Feb 4, 2023
@kelson42
Copy link
Collaborator Author

@pavel-karatsiuba seems ready to implement to me

@pavel-karatsiuba pavel-karatsiuba mentioned this issue Feb 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavel-karatsiuba pavel-karatsiuba

Labels
enhancement good first issue
Projects
None yet
Milestone
1.13.0
Development

Successfully merging a pull request may close this issue.

Refactoring of Logger module openzim/mwoffliner
3 participants
@kelson42 @uriesk @pavel-karatsiuba