Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply proper CSS for proper page display #8

Closed
benoit74 opened this issue Oct 1, 2024 · 1 comment · Fixed by #30
Closed

Apply proper CSS for proper page display #8

benoit74 opened this issue Oct 1, 2024 · 1 comment · Fixed by #30
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@benoit74
Copy link
Contributor

benoit74 commented Oct 1, 2024

Once #7 is implemented, we need to find a solution to apply proper CSS for proper content display.

It looks like there is only two important CSS to retrieve:

<link media="screen" type="text/css" rel="stylesheet" href="https://a.mtstatic.com/@cache/layout/anonymous.css?_=ef44df81294a27ae1883222f0b386038_Z2VvLmxpYnJldGV4dHMub3Jn:site_4038" id="mt-screen-css">

and

<link media="print" type="text/css" rel="stylesheet" href="https://a.mtstatic.com/@cache/layout/print.css?_=7cb5490395b8ed95b0d2f06424a09473:site_4038" id="mt-print-css">
@benoit74 benoit74 added the enhancement New feature or request label Oct 1, 2024
@benoit74 benoit74 added this to the 0.1 milestone Oct 1, 2024
@benoit74 benoit74 self-assigned this Oct 1, 2024
@benoit74
Copy link
Contributor Author

benoit74 commented Oct 8, 2024

For the record, we need to:

  • retrieve all assets referenced in a url in the CSS and store them in the ZIM
  • rewrite CSS to fix all URLs, otherwise we end-up with absolute URLs to online resources and bad URLs to "nowhere"
  • also fetch inline CSS (will be done in a step 2, first two points about deserve their own PR since it is already complex enough)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant