Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Add an option to "yurtctl join" to enable "node autonomy" automatically. #597

Closed
DrmagicE opened this issue Nov 16, 2021 · 6 comments
Assignees
Labels
kind/feature kind/feature kind/good-first-issue kind/good-first-issue wontfix

Comments

@DrmagicE
Copy link
Member

What would you like to be added:
Currently, if the user wants to enable node autonomy for a new node joined by yurtctl join. The user had to call yurtctl markautonomous after yurtctl join, which is inconvenient.

I think the whole process can be simplified by adding an option to yurtctl join to enable ”node autonomy“ automatically.

Why is this needed:

others
/kind feature

@DrmagicE DrmagicE added the kind/feature kind/feature label Nov 16, 2021
@rambohe-ch
Copy link
Member

@DrmagicE It's a good idea to add parameter for yurtctl join for marking autonomous. @zyjhtangtang Do you have any comments?

@zyjhtangtang
Copy link
Contributor

Thanks @DrmagicE , I agree. Can you submit a PR to add this parameter.

@DrmagicE
Copy link
Member Author

@zyjhtangtang Hi, I would like to, but I am afraid I had to finish some jobs in hands (#546 and #527) before starting this one.
@rambohe-ch How about we label this issue as a good-first issue?

@rambohe-ch rambohe-ch added the kind/good-first-issue kind/good-first-issue label Nov 17, 2021
@rambohe-ch
Copy link
Member

@zyjhtangtang Hi, I would like to, but I am afraid I had to finish some jobs in hands (#546 and #527) before starting this one. @rambohe-ch How about we label this issue as a good-first issue?

@DrmagicE done

@adamzhoul
Copy link
Member

I am working on #545
I can pick up this by the way

/assign @adamzhoul

@stale
Copy link

stale bot commented Feb 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 16, 2022
@stale stale bot closed this as completed Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature kind/feature kind/good-first-issue kind/good-first-issue wontfix
Projects
None yet
Development

No branches or pull requests

4 participants