Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] idempotent when execute yurtctl convert or yurtctl revert #485

Closed
adamzhoul opened this issue Sep 22, 2021 · 2 comments
Closed
Labels
kind/feature kind/feature

Comments

@adamzhoul
Copy link
Member

What would you like to be added:

whenever we execute yurtctl convert or yurtctl revert
no matter how many times we execute (same command)

it shall succeed, has no side effect.

Why is this needed:

reduce user mind pressure when try and execute
try yurtctl with different params when last is wrong and failed, without execute yurtctl revert and delete failed k8s job manually.

others
/kind feature

for example:

 yurtctl-disable-node-controller  using sed, multiple execute leads to multiple `-nodelifecycle`

nsenter -t 1 -m -u -n -i -- sed -i 's/--controllers=/--controllers=-nodelifecycle,/g' {{.pod_manifest_path}}/kube-controller-manager.yaml

manually delete k8s job when last is failed. 
@adamzhoul adamzhoul added the kind/feature kind/feature label Sep 22, 2021
@rambohe-ch
Copy link
Member

@adamzhoul Thank you for raising issue.

when user want to convert a native k8s cluster to OpenYurt, yurtctl convert/revert is not a cloud native solution. so another solution(add an yurtcluster operator) has been raised by @gnunu and @SataQiu . you can reference the following issues and docs:

and we are looking forward to YurtCluster operator ready.

@adamzhoul
Copy link
Member Author

operator is certainly a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature kind/feature
Projects
None yet
Development

No branches or pull requests

2 participants