Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missed permissions for yurt-manager (#2127) #2134

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

YunWZ
Copy link

@YunWZ YunWZ commented Aug 22, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Fixs series of missing permissions when install yurt-manager.

Which issue(s) this PR fixes:

Fixes #2127

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

other Note

Signed-off-by: yunweizhan <yunweizhan@gmail.com>
Copy link

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.85%. Comparing base (3713163) to head (f97738c).
Report is 33 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2134      +/-   ##
==========================================
+ Coverage   56.09%   58.85%   +2.75%     
==========================================
  Files         186      209      +23     
  Lines       18092    18924     +832     
==========================================
+ Hits        10149    11137     +988     
+ Misses       6910     6706     -204     
- Partials     1033     1081      +48     
Flag Coverage Δ
unittests 58.85% <ø> (+2.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch
Copy link
Member

@YunWZ Sorry, The reason for the InitCA failed is not rbac pemission, so I commented the issue again.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants