Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-mod-network: typo in wireless.js #7252

Open
efahl opened this issue Aug 24, 2024 · 0 comments
Open

luci-mod-network: typo in wireless.js #7252

efahl opened this issue Aug 24, 2024 · 0 comments

Comments

@efahl
Copy link

efahl commented Aug 24, 2024

This is a trivial one for anyone who is already working on wireless.js:

The non-breaking space character in the badge output has its digits transposed, it's \x0a and it should be \xa0. This causes the badge to be rendered sometimes as two lines, sometimes as three and the jumpy output is pretty annoying. (If you scan the file for \xa0, you'll see the other strings that are properly formatted.)

Here's the line in question:

			value = '---/%d\x0a%s'.format(noiseValue, _('dBm'));

Currently at

https://github.com/openwrt/luci/blob/master/modules/luci-mod-network/htdocs/luci-static/resources/view/network/wireless.js#L83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant