Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for a response when creating a route for a new connection in a mediator. #234

Closed
jakubkoci opened this issue Apr 11, 2021 · 3 comments
Closed

Wait for a response when creating a route for a new connection in a mediator. #234

jakubkoci opened this issue Apr 11, 2021 · 3 comments

Comments

@jakubkoci
Copy link
Contributor

Currently, we don't wait for a response when we're creating a route for a new connection in a mediator.

We just call await this.consumerRoutingService.createRoute(connectionRecord.verkey) in ConnectionsModule.

We should wait for the response from the mediator before we proceed. This requires the implementation of KeylistUpdateResponseHandler and then somehow notifying about the result to the ConnectionsModule.
@jakubkoci jakubkoci mentioned this issue Apr 11, 2021
Merged
@TimoGlastra
Copy link
Contributor

@jakubkoci this is fixed now right?

@TimoGlastra
Copy link
Contributor

@jakubkoci is this fixed?

@TimoGlastra
Copy link
Contributor

This is fixed now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakubkoci @TimoGlastra