fix: w3c anoncreds #1791
Merged
fix: w3c anoncreds #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auer-martin
force-pushed
the
fix/w3c-anoncreds
branch
from
e95d336
to
14d9fef
Compare
TimoGlastra
approved these changes
Mar 11, 2024
Comment on lines
71
to
79
| return new Promise<void>((resolve, reject) => | ||
| socket.send(Buffer.from(JSON.stringify(payload)), (err) => { | ||
| // If the socket was created for this message and we don't have return routing enabled | ||
| // We can close the socket as it shouldn't return messages anymore | ||
| if (isNewSocket && !outboundPackage.responseRequested) { | ||
| socket.close() | ||
| } | ||
|
|
||
| if (err) return reject(err) | ||
| resolve() | ||
| }) | ||
| ) | ||
| // If the socket was created for this message and we don't have return routing enabled | ||
| // We can close the socket as it shouldn't return messages anymore | ||
| // make sure to use the socket in a manner that is compliant with the https://developer.mozilla.org/en-US/docs/Web/API/WebSocket | ||
| // (React Native) and https://github.com/websockets/ws (NodeJs) | ||
| socket.send(Buffer.from(JSON.stringify(payload))) | ||
| if (isNewSocket && !outboundPackage.responseRequested) { | ||
| socket.close() | ||
| } | ||
| } |
There was a problem hiding this comment.
this is already merged right?
auer-martin
force-pushed
the
fix/w3c-anoncreds
branch
from
a3f6646
to
414038a
Compare
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
auer-martin
force-pushed
the
fix/w3c-anoncreds
branch
from
414038a
to
8be403b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: usage of wrong buffer implementation
fix: w3c anoncreds don't require a credential subject id to be present