Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PDF Export #604

Closed
alexfigtree opened this issue Mar 28, 2024 · 7 comments · Fixed by #648
Closed

Fix PDF Export #604

alexfigtree opened this issue Mar 28, 2024 · 7 comments · Fixed by #648
Assignees

Comments

@alexfigtree
Copy link
Contributor

alexfigtree commented Mar 28, 2024

Please describe bug.
PDF save causes crash on both iOS and Android.

Additional context
PDF export needs to work in order to share credentials

@kayaelle
Copy link
Contributor

Added a priority label because issuing of diplomas is imminent and we will want the PDFs to be verifiable.

@alexfigtree alexfigtree moved this from LCW Backlog to To Do (Current sprint) in DCC Engineering Apr 10, 2024
@alexfigtree alexfigtree moved this from To Do (Current sprint) to In Progress in DCC Engineering Apr 17, 2024
@alexfigtree
Copy link
Contributor Author

@alexfigtree
Copy link
Contributor Author

alexfigtree commented May 16, 2024

On hold until team meets again and until we figure out V+ links

@alexfigtree
Copy link
Contributor Author

Currently blocked by: digitalcredentials/web-verifier-plus#126

@alexfigtree
Copy link
Contributor Author

Dev team meeting: Have it function in the same way as the Post to LinkedIn option

@alexfigtree
Copy link
Contributor Author

Implementation details for this ticket: For wallet on share screen:

  1. Check if credential is verified, then
  2. Check if credential has renderMethod field, then
  3. Check if this method has html embedded or a link to an html file
  4. If there is custom html provided by the issuer via a template, in the export to PDF code, look through html for a qr code tag provided by the DCC (let's call it qr_code), so that if we search for {qr_code}, we replace what's in the curly braces with an img element of a QR code of the share link.

Goal is to replace any QR codes provided in a custom html template, NOT to add them.

@alexfigtree alexfigtree linked a pull request Oct 23, 2024 that will close this issue
@alexfigtree alexfigtree changed the title Add QR code to PDFs for verification Fix PDF Export Nov 5, 2024
@alexfigtree
Copy link
Contributor Author

Updated title to reflect work done on PDF fix; QR code implementation now implemented in #650.

@alexfigtree alexfigtree moved this from In Progress to Release Ready in DCC Engineering Nov 5, 2024
@alexfigtree alexfigtree moved this from Release Ready to Done (Deployed) in DCC Engineering Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants