Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training variance models from DS files #131

Closed
yqzhishen opened this issue Aug 9, 2023 · 0 comments · Fixed by #132
Closed

Training variance models from DS files #131

yqzhishen opened this issue Aug 9, 2023 · 0 comments · Fixed by #132

Comments

@yqzhishen
Copy link
Member

yqzhishen commented Aug 9, 2023

In this proposed feature, we will support training variance models from DS files, and even without recordings.

The core of this feature is to let the binarizer load required attribute from DS files instead of reading from transcriptions.csv or extracting from recordings. Given a piece of data named my_item in transcriptions.csv, if DS files binarization is enabled, the binarizer will follow the order of loading attributes below:

  1. Load from the first segment in DS file at <raw_data_dir>/ds/my_item.ds (full name matching).
  2. Load from the k th segment in DS file at <raw_data_dir>/ds/my_item.ds if the item name is in my_item#k pattern.
  3. Load from transcriptions.csv or extract features from the waveform (fallback logic).
  4. Raise an error if none of the resources above are available.

Please note that you still need a transcriptions.csv to declare all data pieces included in binarization. But if you have all required attributes in the DS files, the CSV file can only contain one single column (the name column).

DS files can be exported from OpenUtau for DiffSinger. For support to convert segmented DS files to transcriptions.csv, see openvpi/MakeDiffSinger#9.

@yqzhishen yqzhishen converted this from a draft issue Aug 9, 2023
@yqzhishen yqzhishen moved this from Todo to Testing in DiffSinger Aug 9, 2023
@yqzhishen yqzhishen linked a pull request Aug 9, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from Testing to Done in DiffSinger Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant