Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue] [Snippets] [ARM]: Enable Power, Select, Xor tokenization in CPU Plugin #28162

Open
a-sidorova opened this issue Dec 20, 2024 · 2 comments
Assignees
Labels
category: CPU OpenVINO CPU plugin good first issue Good for newcomers platform: arm OpenVINO on ARM / ARM64

Comments

@a-sidorova
Copy link
Contributor

a-sidorova commented Dec 20, 2024

Context

Snippets is a highly specialized JIT (just-in-time) compiler for computational graphs. It provides a scalable approach to operations' fusions and enablement. As a typical compiler, Snippets have frontend (tokenizer), optimizer and backend (generator).

The first of the Snippets pipeline, Tokenization, identifies parts of the initial ov::Model that can be lowered by Snippets efficiently, and tokenizes them into one whole node - Subgraph.
The second step of the pipeline (Optimizer) is applying common and device-specific optimizations to Subgraph and getting lowered representation of tokenized Subgraph.
Finally, the last stage is code emission. The target generator maps every operation in the IR to a binary code emitter JIT Emitter, which is then used to produce a piece of executable code. As a result, we produce an executable that performs calculations described by the initial input ov::Model.

The purpose of this issue is enabling tokenization of some elementwise operations (Power, Select, Xor) in Snippets for ARM devices. All JIT Emitters are already implemented in the CPU Plugin, so no need to write JIT Emitters.

Prerequisites

Recommended to use ARM CPU based platform for development (e.g. Mac, Raspberry Pi etc). The cross-compilation with an emulator (e.g. QEMU) using is still option: cmake -DCMAKE_TOOLCHAIN_FILE=../cmake/arm64.toolchain.cmake ...

What needs to be done?

Tests

Tests are disabled in default build, so ensure to add -DENABLE_TESTS=ON into cmake command.

GoogleTest is used for testing. CPU functional test target is ov_cpu_func_tests. You can use GoogleTest filter:

./bin/[platform]/[build_type]/ov_cpu_func_tests --gtest_filter="*smoke*Snippets*EltwiseLayerCPUTest*"
./bin/[platform]/[build_type]/ov_cpu_func_tests --gtest_filter="*smoke*SelectLayerCPUTest*"
./bin/[platform]/[build_type]/ov_cpu_func_tests --gtest_filter="*smoke*LogicalLayerTest*"

Examples

Resources

Contact points

@a-sidorova, @dmitry-gorokhov

@a-sidorova a-sidorova added good first issue Good for newcomers category: CPU OpenVINO CPU plugin platform: arm OpenVINO on ARM / ARM64 labels Dec 20, 2024
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Dec 20, 2024
@a-sidorova a-sidorova changed the title [Good First Issue] [Snippets] [ARM]: Enable HSwish, Round, Select, Xor tokenization in CPU Plugin [Good First Issue] [Snippets] [ARM]: Enable Select, Xor tokenization in CPU Plugin Dec 20, 2024
@a-sidorova a-sidorova changed the title [Good First Issue] [Snippets] [ARM]: Enable Select, Xor tokenization in CPU Plugin [Good First Issue] [Snippets] [ARM]: Enable Power, Select, Xor tokenization in CPU Plugin Dec 20, 2024
@sramichetty20019
Copy link

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin good first issue Good for newcomers platform: arm OpenVINO on ARM / ARM64
Projects
Status: Assigned
Development

No branches or pull requests

2 participants