Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always reorder auc inputs after upgrading to pytorch 1.9.x #92

Closed
djdameln opened this issue Jan 28, 2022 · 1 comment
Closed

Always reorder auc inputs after upgrading to pytorch 1.9.x #92

djdameln opened this issue Jan 28, 2022 · 1 comment
Assignees
Labels
Enhancement New feature or request Metrics Metric Component.
Milestone

Comments

@djdameln
Copy link
Contributor

In the AUROC metric computation, we should ideally always reorder the inputs. Currently the lack of support for stable sorting in pytorch 1.8.1 prevents us from doing so (more detailed explanation here). Stable sorting was added in pytorch 1.9.0, so once we upgrade our requirements to that version, we should be able to always reorder the inputs using the stable=True option of torch.sort().

@samet-akcay samet-akcay added Enhancement New feature or request Metrics Metric Component. labels Apr 1, 2022
@samet-akcay samet-akcay added this to the Backlog milestone Apr 4, 2022
@ashwinvaidya17
Copy link
Collaborator

Closing as the current workaround works and this change is blocked by the downstream tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Metrics Metric Component.
Projects
None yet
Development

No branches or pull requests

3 participants