You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 23, 2023. It is now read-only.
Implement simplified Optional<ActiveSpan> and return that. activeSpan() comes from ActiveSpanSource and I'm not sure if it should be touched, so it would need to be returned from a new method.
I'd go with option 1.
The text was updated successfully, but these errors were encountered:
(my recent comment from #134 applies here as well: basically, that this API seems like the right way to do what's being proposed, but that I am hesitant to add API surface area for convenience purposes until we have more experience with ActiveSpan)
In #115
GlobalTracer
gets a new method:One of the common uses of this method will be adding tags/logs to the active span if present, like this:
It's tempting to declare the return type as
Optional
and instead be able to do this:But I guess we can't use java 8 in this project. So instead I propose one of two options:
Runnable
-like interface (something which allows throwing exceptions maybe?) and make this possible:Optional<ActiveSpan>
and return that.activeSpan()
comes fromActiveSpanSource
and I'm not sure if it should be touched, so it would need to be returned from a new method.I'd go with option 1.
The text was updated successfully, but these errors were encountered: