Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parity with the other libraries #47

Closed
ndrwrbgs opened this issue Nov 7, 2017 · 3 comments
Closed

Parity with the other libraries #47

ndrwrbgs opened this issue Nov 7, 2017 · 3 comments
Labels
breaks-instrumentation A breaking change for users of the OpenTracing API breaks-tracers A breaking change for tracers
Milestone

Comments

@ndrwrbgs
Copy link
Contributor

ndrwrbgs commented Nov 7, 2017

The opentracing-csharp library seems to not get much love & attention lately. I was curious if there was interest in bringing it up to parity with more active/maintained opentracing-java, since the languages are similar enough that updating to or even porting the code would be trivial. Many concepts one may want are already there (such as those mentioned directly or indirectly by #36, #44, #35).

This question is obviously motivated by the assumption that given that the java implementation has a large user base, changes to it's exposed API may end up being more practically speaking official than changes actually in the specifications. If, alternatively, it's desirable to keep this library exactly matching the specs with nothing more, then that should be decided/noted explicitly, which would give guidance to the proper action with PRs like #36.

@cwe1ss
Copy link
Member

cwe1ss commented Nov 23, 2017

Sorry for not replying - I’m on a sabbatical right now. Please see #52 for a topic that IMO should be resolved before we do any further changes.

@cwe1ss
Copy link
Member

cwe1ss commented Feb 1, 2018

I'm back and I'll have at least a few days where I can work on OpenTracing. If you guys are ok with it, I'll create several PRs to bring this library up to date with the Java version. I'd rather not merge #50 as it is right now because it doesn't follow C# guidelines and it changes some things which I think should not be changed so I'd like to at least have them discussed briefly. But as I've said there, I'd be happy to wait for changes/other PRs/feedback from @ndrwrbgs as I haven't been active here so I don't want to make anyone unhappy :)

/cc @tedsuo @carlosalberto (I can't see if anyone else is a owner/contributor)

@cwe1ss cwe1ss added this to the 0.11.0 milestone Feb 1, 2018
@cwe1ss
Copy link
Member

cwe1ss commented Feb 10, 2018

No more need for this issue - the work to ensure parity is ongoing in #55 and several PRs.

@cwe1ss cwe1ss closed this as completed Feb 10, 2018
@cwe1ss cwe1ss added breaks-instrumentation A breaking change for users of the OpenTracing API breaks-tracers A breaking change for tracers and removed breaking-change labels Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks-instrumentation A breaking change for users of the OpenTracing API breaks-tracers A breaking change for tracers
Projects
None yet
Development

No branches or pull requests

2 participants