Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix certificate deletion #987

Merged
merged 4 commits into from
Apr 20, 2021
Merged

Fix certificate deletion #987

merged 4 commits into from
Apr 20, 2021

Conversation

outcatcher
Copy link
Contributor

@outcatcher outcatcher commented Apr 15, 2021 •
edited
Loading

Summary of the Pull Request

Remove certificate from listeners if the deletion fails
Fixes #944

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccLBV2ListenerSni
--- PASS: TestAccLBV2ListenerSni (416.19s)
PASS

Process finished with the exit code 0

otc-zuul[bot]
otc-zuul bot previously approved these changes Apr 15, 2021
View reviewed changes
@outcatcher outcatcher self-assigned this Apr 20, 2021
otc-zuul[bot]
otc-zuul bot previously approved these changes Apr 20, 2021
View reviewed changes
@outcatcher outcatcher requested review from a team, lego963 and anton-sidelnikov and removed request for a team April 20, 2021 08:25
@outcatcher outcatcher marked this pull request as ready for review April 20, 2021 08:25
lego963
lego963 previously approved these changes Apr 20, 2021
View reviewed changes
@outcatcher
Remove commented code
cc27e8e 
Minor test change
@outcatcher outcatcher dismissed stale reviews from lego963 and otc-zuul[bot] via cc27e8e April 20, 2021 09:06
@outcatcher outcatcher requested a review from lego963 April 20, 2021 09:07
@outcatcher outcatcher removed their assignment Apr 20, 2021
@outcatcher outcatcher added the gate Merge PR label Apr 20, 2021
@otc-zuul
Copy link

otc-zuul bot commented Apr 20, 2021

Build succeeded.

@otc-zuul otc-zuul bot merged commit d3e1312 into devel Apr 20, 2021
@otc-zuul otc-zuul bot deleted the fix/delete-cert branch April 20, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

@otc-zuul otc-zuul[bot] otc-zuul[bot] approved these changes

@lego963 lego963 lego963 approved these changes

Assignees
No one assigned
Labels
gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timeout when deleting a lb_certificate assigned to sni_container_refs inside a lb_listener
3 participants
@outcatcher @lego963 @anton-sidelnikov