Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDS] Fix template application #1150

Merged
merged 1 commit into from
Jun 23, 2021
Merged

[RDS] Fix template application #1150

merged 1 commit into from
Jun 23, 2021

Conversation

outcatcher
Copy link
Contributor

@outcatcher outcatcher commented Jun 22, 2021

Summary of the Pull Request

Re-apply templates with auto-reset parameters (e.g max_connections)

Restart RDS instance after re-apply if required

Minor style fixes

Fix template values in the test

Fix #934

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccRdsInstanceV3Basic
--- PASS: TestAccRdsInstanceV3Basic (1111.24s)
=== RUN   TestAccRdsInstanceV3ElasticIP
--- PASS: TestAccRdsInstanceV3ElasticIP (683.56s)
=== RUN   TestAccRdsInstanceV3HA
    resource_opentelekomcloud_rds_instance_v3_test.go:93: OS_AVAILABILITY_ZONE_2 is empty
--- SKIP: TestAccRdsInstanceV3HA (0.00s)

Test ignored.
=== RUN   TestAccRdsInstanceV3OptionalParams
--- PASS: TestAccRdsInstanceV3OptionalParams (658.45s)
=== RUN   TestAccRdsInstanceV3Backup
--- PASS: TestAccRdsInstanceV3Backup (689.72s)
=== RUN   TestAccRdsInstanceV3TemplateConfig
restart Rds instance body =  map[restart:{}]
--- PASS: TestAccRdsInstanceV3TemplateConfig (716.29s)
=== RUN   TestAccRdsInstanceV3InvalidDBVersion
--- PASS: TestAccRdsInstanceV3InvalidDBVersion (1.86s)
PASS

Process finished with the exit code 0

Re-apply templates with auto-reset parameters (e.g `max_connections`)

Restart RDS instance after re-apply if required

Minor style fixes

Fix template values in the test
@outcatcher outcatcher requested review from a team, lego963 and anton-sidelnikov and removed request for a team June 22, 2021 16:34
@outcatcher outcatcher added the gate Merge PR label Jun 23, 2021
@otc-zuul
Copy link

otc-zuul bot commented Jun 23, 2021

Build succeeded.

@otc-zuul otc-zuul bot merged commit 084f3b7 into devel Jun 23, 2021
@otc-zuul otc-zuul bot deleted the rds/config-template branch June 23, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gate Merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RDSv3] Adding param_group_id to RDS instance does not seem to work
2 participants