Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider linking to FloorSpaceJS instead of embedding #42

Closed
DavidGoldwasser opened this issue Nov 19, 2019 · 2 comments
Closed

Consider linking to FloorSpaceJS instead of embedding #42

DavidGoldwasser opened this issue Nov 19, 2019 · 2 comments

Comments

@DavidGoldwasser
Copy link
Contributor

DavidGoldwasser commented Nov 19, 2019

Currently a static copy of FloorSpaceJS is embedded in the OpenStudio Application, but I propose linking to the live development version instead.
https://github.com/NREL/floorspace.js

I see three advantages to this approach.

  1. it makes the source code smaller
  2. It makes maintaining the application easier, related to updates to FloorSpaceJS
  3. It gets updates to the application as soon as they go live in FloorSpaceJS

The downside is that it requires you to be online to use, but some elements of FloorSpaceJS, specifically the map overlay, already require internet access. For reference the graphs in the OpenStudio Results measure only render when you are online. I have not gotten any negative feedback about that.

This could still be visually embedded within the application with the same kind of file management. I can understand how it would not be appealing to jump back and forth between the OS App and an external web browser.

@kbenne @asparke2 @jmarrec any thoughts on this either way?

@jmarrec
Copy link
Collaborator

jmarrec commented Nov 20, 2019

I wonder if in all cases we shouldn't fall back to a local version if the CDN is down or if you're offline. https://stackoverflow.com/questions/5257923/how-to-load-local-script-files-as-fallback-in-cases-where-cdn-are-blocked-unavai

Is floorspaceJS used by something else than OS app? Can we enforce thorough testing in Os App before nrel/floorspaceJS is updated?

@jmarrec
Copy link
Collaborator

jmarrec commented Oct 14, 2024

Not pursing this. And I don't want to risk the app breaking if something upstream changes, now that two separate organizations maintain the OS App and floorspace.

@jmarrec jmarrec closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants