Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the coil unit in the air loop #322

Closed
LouYingli opened this issue Mar 9, 2021 · 2 comments
Closed

Delete the coil unit in the air loop #322

LouYingli opened this issue Mar 9, 2021 · 2 comments

Comments

@LouYingli
Copy link

Issue overview

When delete the coil unit in the air loop, the same coil unit in the plant loop cannot be deleted automatically.

Current Behavior

Delete the heating coil in the air loop.

Expected Behavior

The same heating coil in the plant loop should also be deleted automatically.

Steps to Reproduce

  1. Delete the heating coil in the air loop in the HVAC system section.
  2. Run the simulation.
  3. Click show simulation.
    Following is the video link of this bug.
    https://drive.google.com/file/d/1G9W8UsjpSdRXxyZd2EbJ_2NJaWZV5qea/view?usp=sharing

Possible Solution

Delete the heating coil in the plant loop manually.

Details

Environment

  • Platform (Operating system, version): Windows 10 Pro (1909) for Workstations
  • Version of OpenStudioApplication: OpenStudio Application 1.1.0
@LouYingli LouYingli added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Mar 9, 2021
@jmarrec
Copy link
Collaborator

jmarrec commented Mar 16, 2021

Thnaks for the report @LouYingli

I'm going to have to disagree with the wording on this one. Best case it should perhaps ask if you want to also delete it on the PlantLoop if you remove it from the AirLoopHVAC, or remove it from the AirLoopHVAC if you remove it from the PlantLoop. What do you think about this @LouYingli ?

Automatically wiping it from your model makes for a poor UX. There are many very valid justifications for keeping it: if I realize I put the Coil:Heating:Water on the wrong AirLoopHVAC or PlantLoop, I need to a way to be able to place it somewhere else. if we suddenly start deleting it, you have no way of doing this. If we delete it from both loops, but keep it in the model, chances are it'll be forgotten and orphaned (which is likely to cause issues later in E+), and you'd have to re-add it to two loops instead of just one.

@LouYingli
Copy link
Author

Thank you for the clarification. Yes, I mean I want it to be removed from the AirLoopHVAC if I remove it from the PlantLoop. And I want it to be removed from the PlantLoop if I remove it from the AirLoopHVAC.

@jmarrec jmarrec added resolution - Works As Expected ✔️ component - UI and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Oct 14, 2024
@jmarrec jmarrec closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants