Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save As keyboard shortcut missing #315

Closed
MatthewSteen opened this issue Feb 18, 2021 · 2 comments
Closed

Save As keyboard shortcut missing #315

MatthewSteen opened this issue Feb 18, 2021 · 2 comments
Assignees
@macumber
Labels
Enhancement Request New feature or request
Milestone
OpenStudio Applic...

Comments

@MatthewSteen
Copy link

MatthewSteen commented Feb 18, 2021 •
edited
Loading

Enhancement Request

The Save As shortcut is missing from 3.1.0 on Windows (haven't checked Ubuntu).

image

Detailed Description

Possible Implementation

NREL/OpenStudio#3740
#45
@MatthewSteen MatthewSteen added Enhancement Request New feature or request Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Feb 18, 2021
@macumber
Copy link
Collaborator

It looks like that code is still there: https://github.com/openstudiocoalition/OpenStudioApplication/blob/develop/src/openstudio_lib/MainMenu.cpp#L80

The problem is that Qt doesn't define a standard shortcut for Save As on Windows (I checked a few programs, Word uses F12, Notepad++ uses Ctrl+Alt+S). The shortcut is Ctrl+Shift+S on other platforms so maybe we should just set it to Ctrl+Shift+S for all platforms? What do you think @MatthewSteen ?

@macumber macumber added this to the OpenStudio Application 1.2.0 milestone Feb 20, 2021
@macumber macumber removed the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Feb 20, 2021
@macumber macumber self-assigned this Feb 21, 2021
@MatthewSteen
Copy link
Author

MatthewSteen commented Feb 22, 2021 •
edited
Loading

The problem is that Qt doesn't define a standard shortcut for Save As on Windows (I checked a few programs, Word uses F12, Notepad++ uses Ctrl+Alt+S). The shortcut is Ctrl+Shift+S on other platforms so maybe we should just set it to Ctrl+Shift+S for all platforms? What do you think @MatthewSteen ?

Yes, CTRL+SHIFT+S is my recommendation based on what seems to be standard for other apps (VS Code e.g.).

@MatthewSteen MatthewSteen mentioned this issue Aug 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@macumber macumber

Labels
Enhancement Request New feature or request
Projects
None yet
Milestone
OpenStudio Application 1.2.0
Development

No branches or pull requests
2 participants
@macumber @MatthewSteen