Public transport presets inappropriately suggest to change type or name of features

[jarek]

Describe the bug
Per bug reports in the OSM Community Forum and in NSI Github issues, iD suggests to change an Irish Commuter train to an InterCity train, and a London Underground station to an Overground station.

Reports with discussion indicating that problem lies in iD:

• Train route presets inappropriately change type of train osmlab/name-suggestion-index#10469
• iD incorrectly offers to upgrade London Underground stations to London Overground osmlab/name-suggestion-index#10167 (comment)
• https://community.openstreetmap.org/t/bad-name-suggestions-for-train-routes-in-spain-problem-with-preset-or-with-the-concept/125234

To Reproduce
I didn't run into this bug so I'm unsure. See discussions linked.

Expected behavior
Feature types are not incorrectly suggested to be "upgraded".

Screenshots

[linesinalandscape]

To Reproduce

Edit this relation

The "issue" appears immediately, even though the route is correctly tagged (including operator, network, and the wikidata tags).

Further background
As well as offering an incorrect suggestion, the wording "tag as not the same InterCity" is especially confusing here, as the route is not currently tagged as any kind of InterCity.

The NSI preset for the InterCity network is correct in the sense that it contains the right tags for a route on the InterCity network. If the mapper had already selected network=InterCity, the preset would work to check that the wikidata tags for network and operator are consistent. But as commuter and InterCity networks in Ireland have the same operator, the operator alone can not tell us which kind of network a given route belongs to, which may be what ID is assuming. This can not be solved by "geofencing" the presets, as the two types of network run alongside each other in cities.

This is not an isolated situation, and it has a real impact on the map. I found 4 long distance train routes in Spain wrongly tagged as belonging to commuter (Cercanías) networks, created by 4 different mappers who either assumed the ID "upgrade" was correct, or accidentally accepted the upgrade while focused on an unrelated change. The common thread is that like Irish Rail, Renfe operates both commuter and long distance networks in the same area.

[bhousel]

From what I remember we wrote the transit code to prefer matching on network, but fallback to matching on operator.

The best way to fix problems like this is probably to just add the transit networks to NSI that you want the validator to support. (Generally you can fix any problem with NSI by just adding more stuff to NSI).