-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the need for the MapBox Access token when building FHIR Core #3360
Comments
I have tested this by doing the following things to reproduce
Still, I'm able to compile the project without the mapbox sdk token in the local.properties. |
Mapbox has made a significant change to their SDK distribution model. Previously, their Maven repository required authentication with a token, which would cause a 401 Unauthorized error if MAPBOX_SDK_TOKEN was not provided. For reference, here's the error we used to encounter when building the project without providing the MAPBOX_SDK_TOKEN: Recently, Mapbox moved their Android SDK artifacts to Maven Central, making them publicly accessible without requiring authentication. As a result, we can now build the FHIR core app without providing the authentication required in gradle file by the Mapbox SDK while downloading the dependencies. |
Furthermore, these authentication-free changes are available in the newer versions of Mapbox SDK (versions 10.x.x and 11.x.x). Given this improvement, we should consider updating the Mapbox dependencies used in the Kujaku library (https://github.com/onaio/kujaku) to leverage these newer versions and simplify the dependency management process. |
This is blocked by the ticket here - onaio/kujaku#382 |
Describe the feature request.
fhircore
uses MapBox for the Geo-Widget for mapping.Acceptance criteria
Implementation plan (For Engineers)
The plan for implementing the solution e.g. via a description or a check list for the various ordered tasks that will need to be completed.
i.e. Describe how you intend to solve the problem
The text was updated successfully, but these errors were encountered: