JsonQueryObjectModelConverter#toJson: ignores QueryPart#addGuid

[mhendrikxce]

I believe the GUID filter of QueryPart is ignored.

To reproduce:

1. Create a Query with a QueryPart that adds a GUID using addGuid
2. Pass query to ClientIfcModel#queryNew with a IfcModelChangeListener that prints all added
3. Notice that all components are loaded

Problem analysis
The issue is that JsonQueryObjectModelConverter#toJson skips the QueryPart's GUID's.

Adding:

if (queryPart.hasGuids()) {
    ArrayNode guidsNode = OBJECT_MAPPER.createArrayNode();
    queryPartNode.set("guids", guidsNode);
    for (String guid : queryPart.getGuids()) {
        guidsNode.add(guid);
    }
}

under the block processing the oids in the toJson method seems to resolve the issue.

[hlg]

Looks plausible. Thanks for reporting! Would you like to make a pull request?
For reference, here is the OIDs block:

BIMserver/PluginBase/src/org/bimserver/database/queries/om/JsonQueryObjectModelConverter.java

Lines 97 to 103 in 9c9d474

	if (queryPart.hasOids()) {
	ArrayNode oidsNode = OBJECT_MAPPER.createArrayNode();
	queryPartNode.set("oids", oidsNode);
	for (long oid : queryPart.getOids()) {
	oidsNode.add(oid);
	}
	}

[mhendrikxce]

Thanks for the fast reply and follow-up!

I'll follow-up with a PR.

[mhendrikxce]

Read for review: #1257