Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Moco] Streamline post-hoc analyses for models with PositionMotion #3646

Closed
nickbianco opened this issue Dec 12, 2023 · 0 comments
Closed

[Moco] Streamline post-hoc analyses for models with PositionMotion #3646

nickbianco opened this issue Dec 12, 2023 · 0 comments
Assignees
Labels
Moco This label identifies bugs or desired features to aid Moco development

Comments

@nickbianco
Copy link
Member

nickbianco commented Dec 12, 2023

In MocoInverse, after a problem solves, we automatically add back to the MocoTrajectory the kinematics prescribed to the model via the PositionMotion in the model. This works well when solving problems directly from MocoInverse, but if you instead export a MocoInverse problem to a MocoStudy (e.g., to add another cost function), then the kinematics will not be included in the final MocoTrajectory returned to the user.

This means the user needs to add the kinematics back to the trajectory themselves in order to run an analysis, and doing so is unintuitive: example forum post.

We should automate this, or at least provide a convenience function on MocoTrajectory for adding in kinematics from a model's PositionMotion.

Try adding a method to MocoStudy that looks for PositionMotion in the model to add back.

@nickbianco nickbianco added the Moco This label identifies bugs or desired features to aid Moco development label Dec 12, 2023
@nickbianco nickbianco self-assigned this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Moco This label identifies bugs or desired features to aid Moco development
Projects
None yet
Development

No branches or pull requests

2 participants