From 3468605d7b048bd0a996cbaed718167816f31056 Mon Sep 17 00:00:00 2001 From: Greg Kurz Date: Fri, 4 Oct 2024 12:37:29 +0200 Subject: [PATCH] Fix some trivial nits Reported by golint. Signed-off-by: Greg Kurz --- controllers/openshift_controller.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/controllers/openshift_controller.go b/controllers/openshift_controller.go index d43b48bd..4a86b504 100644 --- a/controllers/openshift_controller.go +++ b/controllers/openshift_controller.go @@ -1151,7 +1151,7 @@ func (r *KataConfigOpenShiftReconciler) processKataConfigInstallRequest() (ctrl. // The MCO isn't updating nor do we think it should be. This is // the case e.g. when we're reconciliating a KataConfig change // that doesn't affect kata installation on cluster. - if !isMcoUpdating && r.kataConfig.Status.WaitingForMcoToStart == true { + if !isMcoUpdating && r.kataConfig.Status.WaitingForMcoToStart { r.Log.Info("Waiting for MCO to start updating.") // We don't requeue, an MCP going Updated->Updating will // trigger reconciliation by itself thanks to our watching MCPs. @@ -2176,7 +2176,7 @@ func (r *KataConfigOpenShiftReconciler) isUpdating() bool { } func (r *KataConfigOpenShiftReconciler) createAuthJsonSecret() error { - var err error = nil + var err error pullSecret := &corev1.Secret{} err = r.Client.Get(context.TODO(), types.NamespacedName{Name: "pull-secret", Namespace: "openshift-config"}, pullSecret)