Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait for kube controllers to be ready before starting informers #17860

Merged

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Dec 18, 2017

3.8 pick of #17859

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2017
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Dec 18, 2017
@gnufied
Copy link
Member

gnufied commented Dec 18, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2017
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, gnufied

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@derekwaynecarr
Copy link
Member

/retest

3 similar comments
@soltysh
Copy link
Contributor

soltysh commented Dec 19, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 19, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 19, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 20, 2017

@stevekuznetsov Looks like these router tests are borked. Known problem?

@soltysh
Copy link
Contributor

soltysh commented Dec 21, 2017

/retest

@stevekuznetsov
Copy link
Contributor

Not known to me @knobunc

@soltysh
Copy link
Contributor

soltysh commented Dec 22, 2017

/retest

@soltysh soltysh mentioned this pull request Dec 22, 2017
@soltysh
Copy link
Contributor

soltysh commented Dec 22, 2017

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor Author

deads2k commented Jan 3, 2018

/retest

2 similar comments
@deads2k
Copy link
Contributor Author

deads2k commented Jan 3, 2018

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Jan 4, 2018

/retest

@soltysh
Copy link
Contributor

soltysh commented Jan 4, 2018 via email

@deads2k
Copy link
Contributor Author

deads2k commented Jan 4, 2018

This needs a green e2e before we merge it.

@mfojtik
Copy link
Contributor

mfojtik commented Jan 4, 2018

@deads2k #17966 will make it green when #17985 is resolved.

@deads2k
Copy link
Contributor Author

deads2k commented Jan 5, 2018

/test all

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@soltysh
Copy link
Contributor

soltysh commented Jan 8, 2018

/retest

1 similar comment
@soltysh
Copy link
Contributor

soltysh commented Jan 8, 2018

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 61f0c59 into openshift:release-3.8 Jan 9, 2018
@deads2k deads2k deleted the controller-17-wait-3.8 branch January 24, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants