Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mention internal error when docker registry is unreachable #12269

Merged
merged 1 commit into from
Dec 16, 2016

Conversation

mmilata
Copy link
Contributor

@mmilata mmilata commented Dec 14, 2016

Should make oc new-app output slightly less scary when used in disconnected environment.

Before:

$ oc new-app somegitrepo
...dockerimagelookup.go:220] Docker registry lookup failed: Internal error occurred: Get https://registry-1.docker.io/v2/: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)

After:

$ oc new-app somegitrepo
...dockerimagelookup.go:220] Docker registry lookup failed: Get https://registry-1.docker.io/v2/: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)

Fixes bug 1398330.

Should make oc new-app output less scary when used in disconnected
environment.

Before:

$ oc new-app somegitrepo
...dockerimagelookup.go:220] Docker registry lookup failed: Internal error occurred: Get https://registry-1.docker.io/v2/: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)

After:

$ oc new-app somegitrepo
...dockerimagelookup.go:220] Docker registry lookup failed: Get https://registry-1.docker.io/v2/: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)

Fixes bug 1398330.
@mmilata
Copy link
Contributor Author

mmilata commented Dec 14, 2016

[test]

@bparees bparees self-assigned this Dec 14, 2016
@mmilata
Copy link
Contributor Author

mmilata commented Dec 15, 2016

Flake #11747 and #10928, investigating the third failure.

@mmilata
Copy link
Contributor Author

mmilata commented Dec 15, 2016

Third one looks like transient docker hub outage. [test]

@mmilata
Copy link
Contributor Author

mmilata commented Dec 15, 2016

Flake #11016 (manifesting as #9076). [test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to fa63dcb

@bparees
Copy link
Contributor

bparees commented Dec 15, 2016

lgtm [merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12418/) (Base Commit: 92a2d6f)

@bparees
Copy link
Contributor

bparees commented Dec 15, 2016

ec2 issues. [merge]

@bparees
Copy link
Contributor

bparees commented Dec 16, 2016

flake #11452
[merge]

@bparees
Copy link
Contributor

bparees commented Dec 16, 2016 via email

@bparees
Copy link
Contributor

bparees commented Dec 16, 2016 via email

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to fa63dcb

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12451/) (Base Commit: 8e01869) (Image: devenv-rhel7_5556)

@openshift-bot openshift-bot merged commit dbbeb3f into openshift:master Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants