oc new-app support for "hidden" tag in imagestreams

[jim-minter]

https://trello.com/c/h5JLGnNk/1089-3-support-hidden-tag-on-imagestreamtags-app-creation
[test]

[bparees]

!!! gofmt needs to be run on the following files: 
Try running 'gofmt -s -d [path]'
Or autocorrect with 'hack/verify-gofmt.sh | xargs -n 1 gofmt -s -w'
./pkg/generate/app/imagestreamlookup_test.go
./test/integration/newapp_test.go

[bparees]

why are we claiming we found other tags if we're trying to act like they don't exist?

[bparees]

ah i guess i see it's because if we didn't "find other tags" then it's going to create a match for the imagestream.

if we did find other tags (or lie about having found them), then it will not create that match.

[jim-minter]

The comment I added in the code clearly didn't help much! I've rewritten the comment; maybe it'll be more useful the second time around. This corner is also covered by a test case.

[bparees]

aside from the formatting issue, lgtm.

[bparees]

@jwforres fyi

[jim-minter]

ah, my editor doesn't automatically apply gofmt -s simplifications.

[jim-minter]

@bparees all changes made

[openshift-bot]

Evaluated for origin test up to 1fbb556

[jwforres]

Are the OOTB 1.5 imagestreams going to have images with the hidden tag

…

On Dec 1, 2016 4:31 PM, "Ben Parees" ***@***.***> wrote: @jwforres <https://github.com/jwforres> fyi — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12100 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABZk7RxFcqT5ur_X0ccT0k6XYyVDdLGsks5rDzy5gaJpZM4LBzI0> .

[jim-minter]

@jwforres I don't know if it answers your question, but nodejs 0.10 is already marked hidden in master today, see examples/image-streams/image-streams-centos7.json:

          {
            "name": "0.10",
            "annotations": {
              "openshift.io/display-name": "Node.js 0.10",
              "description": "DEPRECATED: Build and run Node.js 0.10 applications on CentOS 7. For more information about using this builder image, including OpenShift considerations, see https://github.com/sclorg/s2i-nodejs-container/blob/master/0.10/README.md.",
              "iconClass": "icon-nodejs",
              "tags": "hidden,nodejs",
              "supports":"nodejs:0.10,nodejs:0.1,nodejs",
              "version": "0.10",
              "sampleRepo": "https://github.com/openshift/nodejs-ex.git"
            },
            "from": {
              "kind": "DockerImage",
              "name": "openshift/nodejs-010-centos7:latest"
            }
          },

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11923/) (Base Commit: 7b90443)

[bparees]

@jwforres as @jim-minter said, we've already put the tag on the nodejs 0.10 imagestreams, so assuming things get refreshed properly for 1.5, the answer is yes (in fact if they get refreshed again before 1.4 then even 1.4 will have it, as will anyone using master)

[bparees]

lgtm [merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11923/) (Image: devenv-rhel7_5466)

[openshift-bot]

Evaluated for origin merge up to 1fbb556