add *.csproj support to examples/gitserver/hooks/detect-language #12031
Conversation
| @@ -14,6 +14,11 @@ set -o pipefail | |||
| function has { | |||
| [[ -n $(git ls-tree --full-name --name-only HEAD ${@:1}) ]] | |||
| } | |||
| function hasglob { | |||
| git ls-tree --full-name --name-only HEAD | while read NAME; do | |||
| [[ "$NAME" == $1 ]] && return 0 | |||
There was a problem hiding this comment.
isn't this going to compare "*.csproj" with "somefile.csproj" and fail? or is there some bash behavior here i'm not aware of?
There was a problem hiding this comment.
The latter, I believe. See bash(1) under [[ expression ]]: When the == and != operators are used, the string to the right of the operator is considered a pattern and matched according to the rules described below under Pattern Matching, as if the extglob shell option were enabled.
$ mkdir /tmp/empty && cd /tmp/empty
$ >bar.csproj
$ [[ "foo.csproj" == *.csproj ]] && echo yes
yes
$ [[ *.csproj == "foo.csproj" ]] && echo yes
$ [[ "foo.csproj" == "*.csproj" ]] && echo yes
$ [ "foo.csproj" == *.csproj ] && echo yes
$
There was a problem hiding this comment.
yeah i tested w/o the [[ ]] which is why it didn't work for me. looks good, thanks.
|
[merge] |
|
Evaluated for origin merge up to f715aa9 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11711/) (Base Commit: 823513c) (Image: devenv-rhel7_5424) |
@bparees, I accidentally missed this off #11896.