Use custom transport for gitlab communication #11693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@enj PTAL |
enj
reviewed
Nov 1, 2016
| @@ -94,7 +94,11 @@ func (p *provider) GetUserIdentity(data *osincli.AccessData) (authapi.UserIdenti | |||
| req, _ := http.NewRequest("GET", p.userAPIURL, nil) | |||
There was a problem hiding this comment.
Is it safe to ignore this err?
Changes to client / transport LGTM.
There was a problem hiding this comment.
yes, userAPIURL is formed in NewProvider from a known good url and path
|
[merge] |
enj
reviewed
Nov 1, 2016
| res, err := http.DefaultClient.Do(req) | ||
| client := http.DefaultClient | ||
| if p.transport != nil { | ||
| client := &http.Client{Transport: p.transport} |
There was a problem hiding this comment.
d'oh missed it - should be = not :=
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 92eed7a |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10922/) (Base Commit: 751085f) |
|
Evaluated for origin merge up to 92eed7a |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10978/) (Base Commit: 537c0a5) (Image: devenv-rhel7_5299) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11689