to plug service account informer to podsecuritypolicyreview #11612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmichalis
reviewed
Oct 27, 2016
| @@ -97,7 +99,7 @@ func (r *REST) Create(ctx kapi.Context, obj runtime.Object) (runtime.Object, err | |||
| return pspr, nil | |||
| } | |||
|
|
|||
| func getServiceAccounts(psprSpec securityapi.PodSecurityPolicyReviewSpec, client clientset.Interface, namespace string) ([]*kapi.ServiceAccount, error) { | |||
| func getServiceAccounts(psprSpec securityapi.PodSecurityPolicyReviewSpec, saCache *oscache.StoreToServiceAccountLister, namespace string) ([]*kapi.ServiceAccount, error) { | |||
| serviceAccounts := []*kapi.ServiceAccount{} | |||
| // TODO: express 'all service accounts' | |||
There was a problem hiding this comment.
Do we still want to do this? It seems to me that you want just the service accounts associated with the psp, right?
|
Looks good, had an unrelated question. |
sdminonne
force-pushed
the
sa_informer_in_posecuritypolicyreview
branch
from
0d677a1
to
dc761fb
Compare
|
[test] |
|
Evaluated for origin test up to dc761fb |
|
@mfojtik this LGTM - tag when possible |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10787/) (Base Commit: 4e99352) |
|
@mfojtik mind merging this one? |
|
[merge] |
|
Flake #11661. |
|
re [merge] |
|
Evaluated for origin merge up to dc761fb |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10787/) (Base Commit: 21040e2) (Image: devenv-rhel7_5300) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Kargakis as discussed here
@soltysh fyi