adding 'oc set resources' #11384
adding 'oc set resources' #11384
Conversation
|
Don't we want this upstreamed at the same time? |
|
@liggitt: This just merged upstream as kubernetes/kubernetes#27206. @eparis and I wanted to get this into OpenShift 1.4 so we have to carry our own version for a release. When the kubectl set stuff makes it into OpenShift, this version should be replaced. But since @JacobTanenbaum implemented both, he is keeping the OpenShift version as close to the upstream Kube version as possible, while still working within the existing 'oc set' framework. Is there a better approach that we should take to get this in? |
JacobTanenbaum
force-pushed
the
add_limit
branch
7 times, most recently
from
4c0079c to
49d547e
Compare
|
@fabianofranz maybe you can help here... |
|
[test] |
|
@openshift/cli-review @Kargakis |
|
[test] last failure was #11240 (logs https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_integration/7278/consoleText) |
|
Why don't you cherry-pick kubernetes/kubernetes#27206 in our vendor dir as an UPSTREAM commit instead of bringing it in oc? |
+1, if the command code is the same we should cherry-pick as an UPSTREAM commit. Documentation here. |
openshift-bot
added
the
needs-rebase
JacobTanenbaum
force-pushed
the
add_limit
branch
from
fd4a40e to
9f2f8ce
Compare
openshift-bot
removed
the
needs-rebase
|
The commit message should be: UPSTREAM: 27206: Add kubectl set resources |
|
And you also need to update completions and docs: ./hack/update-generated-completions.sh |
JacobTanenbaum
force-pushed
the
add_limit
branch
2 times, most recently
from
470b556 to
e408a01
Compare
|
[test] |
|
[test] in case @JacobTanenbaum was being ignored |
|
[merge] |
|
[test] since Jenkins seemed to explode on the last one. |
JacobTanenbaum
force-pushed
the
add_limit
branch
from
e408a01 to
b7e93bb
Compare
|
[test] |
add kubectl set resources
JacobTanenbaum
force-pushed
the
add_limit
branch
from
b7e93bb to
c2def54
Compare
|
[test] |
|
[test][merge] |
|
Evaluated for origin test up to c2def54 |
|
Evaluated for origin merge up to c2def54 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10500/) (Base Commit: 2047a73) (Image: devenv-rhel7_5232) |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10499/) (Base Commit: 2047a73) |
intial commit to add a command to set resource requests/limits on
running pods.