Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployments: use centos:centos7 instead of deployment-example image #11261

Merged
merged 1 commit into from
Oct 10, 2016

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Oct 7, 2016

Closes #11256
Closes #11257

@0xmichalis
Copy link
Contributor

[test]

@0xmichalis
Copy link
Contributor

Should fix both #11257 and #11256

@0xmichalis
Copy link
Contributor

LGTM

- image: "docker.io/openshift/deployment-example:v1"
- image: "docker.io/centos:centos7"
command:
- /bin/sleep
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation is wrong

@mfojtik
Copy link
Contributor Author

mfojtik commented Oct 10, 2016

[test]

@mfojtik
Copy link
Contributor Author

mfojtik commented Oct 10, 2016

yeah I fixed that on Friday, the tests pass this was some weird unit test failure.

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 57833ac

@0xmichalis
Copy link
Contributor

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9795/)

@0xmichalis
Copy link
Contributor

#11074 [merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 57833ac

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 10, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9799/) (Image: devenv-rhel7_5159)

@openshift-bot openshift-bot merged commit 606716e into openshift:master Oct 10, 2016
@mfojtik mfojtik deleted the deployment-flakes branch September 5, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants