Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the ability to skip tests that require the AllowAll identity p… #11254

Closed
wants to merge 1 commit into from

Commits on Oct 6, 2016

  1. Adding the ability to skip tests that require the AllowAll identity p…

    …rovider
    
    Conformance tests are useful in some running clusters however admin can't
    always want to disable authentication.  The main thing this commit does is add
    a new optional regex for excluding tests.  The TEST_ONLY logic was flipped to
    make it a little easier to read (and I don't think it was actually working
    before).
    
    Running with these tests skipped against the latest Origin 1.4 codebase:
    
    -------
    Ran 115 of 564 Specs in 2097.700 seconds
    SUCCESS! -- 115 Passed | 0 Failed | 0 Pending | 449 Skipped PASS
    
    Ran 7 of 564 Specs in 162.981 seconds
    SUCCESS! -- 7 Passed | 0 Failed | 0 Pending | 557 Skipped PASS
    -------
    
    Another important difference is the fact that the conformance tests are now run
    with the extended.test binary instead of with ginkgo.  Ginkgo doesn't ship with
    the official builds of Origin or OpenShift Container platform and it seems like
    the differences between the two ways of running the tests are arbitrary. This
    allows someone to run the tests as follows:
    
    PARALLEL_NODES=1 KUBECONFIG=/etc/origin/master/admin.kubeconfig EXTENDEDTEST="/usr/libexec/atomic-openshift/extended.test" TEST_ONLY=true OPENSHIFT_SKIP_ALLOWALL_AUTH_TESTS=true ./test/extended/conformance.sh
    brenton committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    9147bba View commit details
    Browse the repository at this point in the history