Created a script to run tito builds and upack leftover artifacts #11248
Conversation
stevekuznetsov
force-pushed
the
skuznets/makefile-rpm-release
branch
9 times, most recently
from
76d9cee
to
e220924
Compare
openshift-bot
added
the
needs-rebase
| # | ||
| # Example: | ||
| # make release | ||
| rpm-release: clean build-rpms |
There was a problem hiding this comment.
Actually release-rpms
There was a problem hiding this comment.
Actually, one sec.
build is intended to build for local use. Release is intended to build for redistribution. "official-release" should push artifacts someplace (tool for inside out management), while release is a tool for someone who manages the artifacts themselves.
There was a problem hiding this comment.
So what's your take on this? You'll get RPMs and I imagine you could email them to someone ... release-rpms?
There was a problem hiding this comment.
release-rpms is good for now.
| os::build::setup_env | ||
| os::util::environment::setup_tmpdir_vars "build-rpm-release" | ||
|
|
||
| if [[ "${OS_ONLY_BUILD_PLATFORMS:-}" == 'linux/amd64' ]]; then |
There was a problem hiding this comment.
What's the difference between make_redistributable? If I ran brew/tito on linux/386, what happens?
There was a problem hiding this comment.
If it's set to 1, we build all of the clients. If not, we only build the linux/amd64 one.
https://github.com/openshift/origin/blob/master/origin.spec#L200-L206
There was a problem hiding this comment.
I would expect make_redistributable to build the platform I am on.
There was a problem hiding this comment.
That's not what the team building the specfile has decided to do with that option ... do you want me to propose that change to them first?
There was a problem hiding this comment.
It's fine for now. I don't think it makes a ton of sense in the future, but can live with it.
openshift-bot
added
needs-rebase
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/makefile-rpm-release
branch
from
e220924
to
9259db0
Compare
|
Updated to |
|
LGTM [merge] |
|
Evaluated for origin merge up to 9259db0 |
|
[Test]ing while waiting on the merge queue |
stevekuznetsov
changed the title
|
Evaluated for origin test up to 9259db0 |
openshift-bot
removed
the
needs-rebase
|
@danmcp please re-tag |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10534/) (Image: devenv-rhel7_5236) |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10534/) (Base Commit: 84cddbc) |
|
[merge] On Mon, Oct 24, 2016 at 10:19 AM, OpenShift Bot notifications@github.com
|
|
[merge] On Sat, Oct 22, 2016 at 8:29 PM, OpenShift Bot notifications@github.com
|
|
@smarterclayton this went into |
| fi | ||
|
|
||
| os::log::info 'Building Origin release RPMs with tito...' | ||
| tito_tmp_dir="${BASETMPDIR}/tito" |
There was a problem hiding this comment.
why isn't this _output/tito or _output/rpm?
There was a problem hiding this comment.
Outputs a bunch of other nonsense we don't want to keep around. I copy the important bits back at the end.
|
|
||
| # migrate the tito artifacts to the Origin directory | ||
| mkdir -p "${OS_OUTPUT}" | ||
| cp -r "${tito_output_directory}"/* "${OS_OUTPUT}" |
There was a problem hiding this comment.
why not mv? Creates extra content we don't need probably.
There was a problem hiding this comment.
Good question, should be a mv
| mkdir -p "${OS_OUTPUT}" | ||
| cp -r "${tito_output_directory}"/* "${OS_OUTPUT}" | ||
| mkdir -p "${OS_LOCAL_RELEASEPATH}" | ||
| cp "${tito_tmp_dir}"/x86_64/*.rpm "${OS_LOCAL_RELEASEPATH}" |
There was a problem hiding this comment.
Not sure how I feel about this. On the one hand everything is in the same spot. On the other, we'll eventually have multi arch. Hrm.
There was a problem hiding this comment.
We could set up the $basearch/$version directories using tito I think and then we can potentially have the createrepo call most of us will do an optional part of the build here, and we could move the entire multiarch repo root.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
replaces #11244
.cc @smarterclayton