Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make registry tests using docker.socket dockerless #20079

Open
miminar opened this issue Jun 22, 2018 · 5 comments
Open

Make registry tests using docker.socket dockerless #20079

miminar opened this issue Jun 22, 2018 · 5 comments

Comments

@miminar
Copy link

miminar commented Jun 22, 2018

The tests using the docker socket fail because the access is not granted anymore in pods.
Therefore they are now being marked with [local].

This issue is a reminder to rewrite the tests in a dockerless way.

See the related discussion:

And related [local] PRs:

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 1, 2018
@bparees
Copy link
Contributor

bparees commented Oct 30, 2018

/lifecycle frozen
/remove-lifecycle stale

/assign @dmage

This is more urgent than before as these tests are not being run anywhere anymore i do not believe, until we remove the local tag.

@openshift-ci-robot openshift-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 30, 2018
@bparees
Copy link
Contributor

bparees commented Oct 31, 2018

might be possible to use oc image mirror to push an image from docker hub into the registry for these tests, too.

@gitsan13
Copy link

gitsan13 commented Sep 7, 2022

I would like to contribute to this issue. Kindly guide me through the steps as I am a newbie in this field.

@dmage
Copy link
Contributor

dmage commented Sep 7, 2022

@gitsan13 one set of tests that are marked as [Local] is here:

var _ = g.Describe("[sig-imageregistry][Feature:ImagePrune][Serial][Suite:openshift/registry/serial][Local] Image prune", func() {

But it's a pretty tricky issue. Why did you choose it? Before you start working on any test, you need to get a working OpenShift or OKD cluster and learn how to run tests. This alone can be overwhelming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants