Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openshift_checks: refactor check results #4913

Merged
merged 2 commits into from
Aug 8, 2017
Merged

openshift_checks: refactor check results #4913

merged 2 commits into from
Aug 8, 2017

Commits on Aug 2, 2017

  1. openshift_checks: add property to track 'changed' 

    Introduced the 'changed' property for checks that can make changes to
track whether they did or not. Rather than the check's own logic having
to track this and include it in the result hash, just set the property
and have the action plugin insert it in the result hash after running
(even if there is an exception).

Cleared out a lot of crufty "changed: false" hash entries.
    @sosiouxme
    sosiouxme committed Aug 2, 2017
    Configuration menu
    Copy the full SHA
    bf0828b View commit details
    Browse the repository at this point in the history

  2. openshift_checks: refactor logging checks 

    Turn failure messages into exceptions that tests can look for without
depending on text meant for humans.
Turn logging_namespace property into a method.
Get rid of _exec_oc and just use logging.exec_oc.
    @sosiouxme
    sosiouxme committed Aug 2, 2017
    Configuration menu
    Copy the full SHA
    06a6fb9 View commit details
    Browse the repository at this point in the history