Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics: grant hawkular namespace listener role #4855

Merged
merged 1 commit into from
Jul 26, 2017
Merged

Metrics: grant hawkular namespace listener role #4855

merged 1 commit into from
Jul 26, 2017

Conversation

mwringe
Copy link
Contributor

@mwringe mwringe commented Jul 24, 2017

An update to the Hawkular component requires that it be able to list and listen on namespace events.

This will create a new cluster role and grant it to the hawkular service account

@mwringe
Copy link
Contributor Author

mwringe commented Jul 25, 2017

@sdodson @jcantrill could someone review this please? We need this for to fix a blocker issue.

@ewolinetz ewolinetz self-requested a review July 25, 2017 14:45
ewolinetz
ewolinetz approved these changes Jul 25, 2017
View reviewed changes
Copy link
Contributor

@ewolinetz ewolinetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, eventually we should convert all of these template tasks to module calls to create the objects now instead of looping over them later

@ewolinetz
Copy link
Contributor

aos-ci-test

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for 5017824 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for 5017824 (logs)

@ewolinetz
Copy link
Contributor

[merge]

@ewolinetz
Copy link
Contributor

@mwringe is this required for 3.6 as well?

@mwringe
Copy link
Contributor Author

mwringe commented Jul 25, 2017

@ewolinetz yes, its required for 3.6, I will submit a pr for the 3.6 branch. I usually try and get this in master before backporting to older versions

@mwringe mwringe mentioned this pull request Jul 25, 2017
Merged
@mwringe
Copy link
Contributor Author

mwringe commented Jul 25, 2017

The 3.6 backport is available here: #4865

@ewolinetz
Copy link
Contributor

merge flaked on openshift/origin#15356
[merge]

@openshift-bot
Copy link

[test]ing while waiting on the merge queue

@openshift-bot
Copy link

Evaluated for openshift ansible test up to 5017824

@openshift-bot
Copy link

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/361/) (Base Commit: d1ee0ee) (PR Branch Commit: 5017824)

@openshift-bot
Copy link

openshift-bot commented Jul 26, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 1

@mwringe
Copy link
Contributor Author

mwringe commented Jul 26, 2017

Is the test failures something wrong with the CI?
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible_extended_conformance_install_with_status_check/878/console
"rm: cannot remove ‘/tmp/etcd/member’: Permission denied"

@ewolinetz
Copy link
Contributor

merge flaked on openshift/origin#15356
[merge]

@openshift-bot
Copy link

Evaluated for openshift ansible merge up to 5017824

@sdodson sdodson merged commit 7e7998b into openshift:master Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewolinetz ewolinetz ewolinetz approved these changes

Assignees
No one assigned
Labels
affects_3.6 backported_3.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mwringe @ewolinetz @openshift-bot @sdodson