-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bz1466783 etcd ips in masters no proxy #4806
Bz1466783 etcd ips in masters no proxy #4806
Conversation
aos-ci-test |
[test] |
Also add filter names of filters that failed me for to their error messages so you can figure out which filter threw an exception when you're debugging log files.
de0c094
to
58b3a05
Compare
aos-ci-test |
[test] |
rebased on latest master (includes the dependent PR) |
@@ -194,10 +194,10 @@ def oo_select_keys_from_list(data, keys): | |||
""" | |||
|
|||
if not isinstance(data, list): | |||
raise errors.AnsibleFilterError("|failed expects to filter on a list") | |||
raise errors.AnsibleFilterError("|oo_select_keys_from_list failed expects to filter on a list") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this makes me very happy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Flake openshift/origin#15356 |
re[test] |
Evaluated for openshift ansible test up to 58b3a05 |
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/356/) (Base Commit: 0883acb) (PR Branch Commit: 58b3a05) |
@sdodson same flake as before. Can you work you dodsonesque magic on this? |
flake on openshift/origin#15356 |
Depends on...
Depends on Fix proxy settings. For real. For actual this time. #4794Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1466783
Add etcd host IPs to master config files in HA environments when a proxy is in use.