Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bz1466783 etcd ips in masters no proxy #4806

Merged

Conversation

tbielawa
Copy link
Contributor

@tbielawa tbielawa commented Jul 20, 2017

Depends on...


Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1466783

Add etcd host IPs to master config files in HA environments when a proxy is in use.

@tbielawa tbielawa changed the title [WIP] Bz1466783 etcd ips in masters no proxy Bz1466783 etcd ips in masters no proxy Jul 20, 2017
@tbielawa tbielawa requested review from sdodson and ashcrow July 21, 2017 14:34
@tbielawa
Copy link
Contributor Author

aos-ci-test

@tbielawa
Copy link
Contributor Author

[test]

@openshift-bot
Copy link

error: aos-ci-jenkins/OS_3.6_containerized for 7fa5afb (logs)

@openshift-bot
Copy link

error: aos-ci-jenkins/OS_3.6_NOT_containerized for 7fa5afb (logs)

Also add filter names of filters that failed me for to their error
messages so you can figure out which filter threw an exception when
you're debugging log files.
@tbielawa tbielawa force-pushed the bz1466783_etcd_ips_in_masters_no_proxy branch from de0c094 to 58b3a05 Compare July 21, 2017 18:37
@tbielawa
Copy link
Contributor Author

aos-ci-test

@tbielawa
Copy link
Contributor Author

[test]

@tbielawa
Copy link
Contributor Author

rebased on latest master (includes the dependent PR)

@@ -194,10 +194,10 @@ def oo_select_keys_from_list(data, keys):
"""

if not isinstance(data, list):
raise errors.AnsibleFilterError("|failed expects to filter on a list")
raise errors.AnsibleFilterError("|oo_select_keys_from_list failed expects to filter on a list")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes me very happy

Copy link
Member

@sdodson sdodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for 58b3a05 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for 58b3a05 (logs)

@tbielawa
Copy link
Contributor Author

Flake openshift/origin#15356

@tbielawa
Copy link
Contributor Author

re[test]

@openshift-bot
Copy link

Evaluated for openshift ansible test up to 58b3a05

@openshift-bot
Copy link

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/356/) (Base Commit: 0883acb) (PR Branch Commit: 58b3a05)

@tbielawa
Copy link
Contributor Author

@sdodson same flake as before. Can you work you dodsonesque magic on this?

@sdodson
Copy link
Member

sdodson commented Jul 24, 2017

flake on openshift/origin#15356

@sdodson sdodson merged commit e357198 into openshift:master Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants