[healthchecks] the package_version check always checks for master/node packages regardless of host group

[codificat]

Description

When running playbooks/byo/openshift-preflight/check.yml, the package_version check reports failures on hosts that can't access the atomic-openshift-{master,node} packages even when this is expected, e.g. on etcd or lb hosts.

Version

openshift-ansible-3.5.3-1-521-g3125e72

Steps To Reproduce

1. Have a cluster with [etcd], [lb] and/or additional "auxiliary" host groups
2. Run the playbooks/byo/openshift-preflight/check.yml playbook

Expected Results

Hosts would not report a failure when they have access to the packages they need.

Observed Results

Hosts that don't have access to atomic-openshift-{master,node} packages in their configured repos are reported as failed, even when the hosts don't need these packages.
Describe what is actually happening.

$ ansible-playbook playbooks/byo/openshift-preflight/check.yml
[...]
Failure summary:

  1. Host:     etcd2.example.com
     Play:     run OpenShift health checks
     Task:     openshift_health_check
     Message:  One or more checks failed
     Details:  {'package_availability': {'_ansible_parsed': True,
                                         u'changed': False,
                                         u'invocation': {u'module_args': {u'packages': []}}},
                'package_update': {'_ansible_parsed': True,
                                   u'changed': False,
                                   u'invocation': {u'module_args': {u'packages': []}}},
                'package_version': {'_ansible_parsed': True,
                                    u'failed': True,
                                    u'invocation': {u'module_args': {u'prefix': u'atomic-openshift',
                                                                     u'version': u'v3.4'}},
                                    u'msg': u'Not all of the required packages are available at requested version 3.4:\n  atomic-openshift\n  atomic-openshift-master\n  atomic-openshift-node\nPlease check your subscriptions and enabled repositories.'}}

Additional Information

The inventory file used here has:

[OSEv3:children]
masters
nodes
etcd
lb
dns

# [...]

[etcd]
etcd2.example.com
# [...]

[lb]
lb.example.com

the hosts in etcd, lb and dns groups all fail the check.