Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preStart lifecyle event support #4901

Closed
feloy opened this issue Jul 9, 2021 · 1 comment · Fixed by #4909
Closed

preStart lifecyle event support #4901

feloy opened this issue Jul 9, 2021 · 1 comment · Fixed by #4909
Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).

Comments

@feloy
Copy link
Contributor

feloy commented Jul 9, 2021

/kind feature

Which functionality do you think we should add?

It should be possible to add a preStart event to a component, for odo to define an init container in the deployment to run the specified command.

Why is this needed?

Running s2i components needs to run a specific init container to copy files to the persistent volume.
@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jul 9, 2021
@kadel
Copy link
Member

kadel commented Jul 9, 2021

/priority high

@openshift-ci openshift-ci bot added the priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). label Jul 9, 2021
This was referenced Jul 9, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

preStart events support feloy/odo
2 participants
@kadel @feloy