Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Flat vendor directory #1914

Closed
mjudeikis opened this issue Jun 27, 2019 · 1 comment · Fixed by #2745
Closed

[RFE] Flat vendor directory #1914

mjudeikis opened this issue Jun 27, 2019 · 1 comment · Fixed by #2745

Comments

@mjudeikis
Copy link
Contributor

When revendoring installer project we are running into the issue with a double vendor directory for terraform and main project dependencies.

https://github.com/openshift/installer/tree/master/pkg/terraform/exec/vendor
https://github.com/openshift/installer/tree/master/vendor

When vendoring in installer its gets either truncated or squashed by dep.

It would be good somehow align vendor directories so we would not have this hack and have a flat vendor for the project.

@abhinavdahiya
Copy link
Contributor

Should be fixed with #2745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants