Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Secret component allows saving SSH key without trailing newline #6858

Closed
willhaines opened this issue Oct 6, 2020 · 0 comments · Fixed by #6859
Closed

Create Secret component allows saving SSH key without trailing newline #6858

willhaines opened this issue Oct 6, 2020 · 0 comments · Fixed by #6859

Comments

@willhaines
Copy link

If you create an SSH key secret by pasting the contents without an empty line at the end, then git clone will fail to authenticate.

okd-ssh-key-bug

Simply adding an empty line to the secret contents fixes the problem. IMHO, this would probably be best fixed upstream in SSH, however there is precedent in other projects to simply work around this behaviour by making sure SSH private keys end with a newline character:

jenkinsci/ssh-credentials-plugin#33
semaphoreui/semaphore#183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant